[BACKLOG-37991] WCAG - Manage Data souces dialog on Safari - bad ui format #1020
Conversation
varuntangirala
requested review from
dcleao,
soagarwal1,
NJtwentyone and
singletonc
|
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
✅ Build finished in 7m 4sBuild command: mvn clean verify -B -e -Daudit -amd -pl widgets👌 All tests passed! Tests run: 345, Failures: 0, Skipped: 0 Test Results ℹ️ This is an automatic message |
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
| @@ -489,13 +501,26 @@ public void setFocusableRow( int row, boolean focus ) { | |||
| } | |||
| } | |||
|
|
|||
| protected class MyScrollTable extends ScrollTable { | |||
There was a problem hiding this comment.
Not a blocker. Consider a more specific class name.
| border-left-width: 1px; | ||
| } | ||
|
|
||
| .safari #datasourceAdminDialog .gwt-ScrollTable :is(.headerWrapper, .dataWrapper) { |
There was a problem hiding this comment.
Some of these rules are the same and could be combined:
selector1,
selector2,
selector3 {
styles
}
There was a problem hiding this comment.
Can you clarify which ones? Not spotting.
| padding-right: 10px; | ||
| } | ||
| /* end for styling manage data sources dialog for safari browser */ | ||
|
|
||
| :where(.responsive#general-datasource-window) #general-settings-box { | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
could add the other border-box rule selectors here or even create/look for a rule that adds the border-box style to any element that has that class
There was a problem hiding this comment.
We group CSS properties under the same CSS rule, using the "OR" combinator, within the same context / component. In this case, I think that keeping the safari rules in the "Safari override / hack context" is more important. Although the Safari styles are based on the normal ones, the approach takes a very distinct path, which is very literally a hack. Splitting the hack across multiple places would perhaps make it even harder to understand.
I agree this is debatable 👍
@pentaho/wcag Please review and merge along with
pentaho/pentaho-platform#5529