Initial commit of Webttle code covering Execution flow and Preview Rows #9212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sVarma1992
reviewed
Mar 6, 2024
There was a problem hiding this comment.
Please don't change anything that is not our code, even indentations
sVarma1992
reviewed
Mar 6, 2024
| import java.io.IOException; | ||
| import java.io.PrintWriter; | ||
| import java.util.List; | ||
|
|
| import java.io.PrintWriter; | ||
| import java.util.List; | ||
|
|
||
|
|
There was a problem hiding this comment.
add class level javadoc here
| @@ -184,7 +185,7 @@ public void doGetTransformationNotFoundTest() throws Exception { | |||
| HttpServletRequest mockHttpServletRequest = mock( HttpServletRequest.class ); | |||
| HttpServletResponse mockHttpServletResponse = mock( HttpServletResponse.class ); | |||
| Trans trans = initMocksForTransExecution( mockHttpServletRequest, mockHttpServletResponse ); | |||
| doThrow( new KettleException( "Unable to find transformation" ) ).when( executeTransServlet ).executeTrans( trans ); | |||
| doThrow( new KettleException( "Unable to find transformation" ) ).when( executeTransServlet ).executeTrans( trans, new HashMap<>()); | |||
There was a problem hiding this comment.
i think better to override this method for our approach and handle it java rather than doing it in test class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first commit for Kettle engine related changes related to "Webttle". This contains: