Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPP-4826] Upgrade Vulnerable Hibernate to 5.4.24 #5464

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[PPP-4826] Upgrade Vulnerable Hibernate to 5.4.24 #5464

merged 1 commit into from
Dec 6, 2023

Conversation

tkafalas
Copy link
Contributor

@tkafalas tkafalas commented Dec 4, 2023

No description provided.

@tkafalas tkafalas requested a review from a team as a code owner December 4, 2023 15:41
@buildguy

This comment has been minimized.

Sign in to view
peterrinehart
peterrinehart requested changes Dec 5, 2023
View reviewed changes
extensions/src/test/resources/web-solution/system/pentaho.xml Outdated
@@ -28,7 +28,8 @@
-->

<cache-provider>
<class>net.sf.ehcache.hibernate.SingletonEhCacheProvider</class>
<!--<class>net.sf.ehcache.hibernate.SingletonEhCacheProvider</class>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep this commented line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Missed it

repository/src/main/java/org/pentaho/platform/repository/hibernate/usertypes/BlobUserType.java Outdated
import org.hibernate.util.SerializationHelper;
//EqualsHelper removed after hibernate-core-5.3.1.Final.jar
//import org.hibernate.util.EqualsHelper;
//This SerializationHelper was moved from:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to keep these comments here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I'd keep this one in, in case something crops up

...y/src/main/java/org/pentaho/platform/repository/hibernate/usertypes/EmptyStringUserType.java Outdated
import org.hibernate.usertype.UserType;
import org.hibernate.util.EqualsHelper;
//EqualsHelper removed after hibernate-core-5.3.1.Final.jar
//import org.hibernate.util.EqualsHelper;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment necessary? The block below seems to document everything well enough.

...ry/src/main/java/org/pentaho/platform/repository/hibernate/usertypes/LongStringUserType.java
@@ -32,6 +32,7 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.hibernate.HibernateException;
import org.hibernate.engine.spi.SharedSessionContractImplementor;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in here are fine, please update the copyright header.

@hitachivantarasonarqube HitachiVantaraSonarQube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition E Reliability Rating on New Code (is worse than A)
Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition 4.1% 4.12% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@buildguy
Copy link
Collaborator

buildguy commented Dec 6, 2023

⚠️ Build finished in 2h 25s

Build command:

mvn clean verify -B -e -Daudit -amd

⛔ Failed Tests

⛈️ 3 test(s) failed:

org.pentaho.platform.util.versionchecker.PentahoVersionCheckReflectHelperTest.performVersionCheckTest (click to expand)

${result.errorDetails}

org.pentaho.test.platform.repository.RepositoryTestCase.testNothing on testNothing(org.pentaho.test.platform.repository.RepositoryTestCase) (click to expand)

${result.errorDetails}

org.pentaho.test.platform.repository.RepositoryTestCase.testNothing (click to expand)

${result.errorDetails}

Tests run: 2877, Failures: 3, Skipped: 1    Test Results

ℹ️ This is an automatic message

@ddiroma ddiroma merged commit 0872fba into pentaho:master Dec 6, 2023
2 of 4 checks passed
@ddiroma ddiroma mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterrinehart peterrinehart peterrinehart requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkafalas @buildguy @peterrinehart @ddiroma