-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Merge scheduler-plugin into master #5493
Conversation
Getting the user-console module to a compiling state.
[BACKLOG-38035] SCHEDULER - moving the scheduler UI into the new sche…
[BACKLOG-38225] SCHEDULER - Make scheduler-plugin/UI basic functional…
Rebasing to 10.1.0.0
[BACKLOG-38225] SCHEDULER - Make scheduler-plugin/UI basic functionality work again
…m into TestBranch # Conflicts: # scheduler/src/main/java/org/pentaho/platform/scheduler2/quartz/EmbeddedQuartzSystemListener.java # scheduler/src/main/java/org/pentaho/platform/scheduler2/quartz/QuartzScheduler.java # scheduler/src/main/java/org/pentaho/platform/scheduler2/versionchecker/EmbeddedVersionCheckSystemListener.java # scheduler/src/main/java/org/pentaho/platform/scheduler2/ws/DefaultSchedulerService.java
…mmit) Squashed commits: [3c8ef0f] BACKLOG-38036 - Changes to allow scheduler-plugin to startup
[BACKLOG-38225] SCHEDULER - Make scheduler-plugin/UI basic functional…
…m into scheduler-plugin
Scheduler plugin
…een scheduler and extensions
BACKLOG-38036 - Moved classes to fix circular dependency problem betw…
BACKLOG-38036 - Refactor of SchedulerResource
[BACKLOG-37905] - Added code to resolve email groups into individual emails when a schedule runs.
…an empty exportManifest.xml
…m into scheduler-plugin
Scheduler plugin
endpoints in plugins. Endpoints must be defined in a plugin.ws.spring.xml file within the plugin, endpoint path must be of the form webservices/plugins/<plugin-id>/<endpoint>. Updated filter to handle relocating scheduler web service endpoint.
…sed from jax-rs api
[BACKLOG-39324] Created PentahoPluginWSSpringServlet to handle jaxws
[BACKLOG-37872] Fixed session scope for Pentaho plugin spring beans used from jax-rs api
merge commits from master
pentaho-streaming-kafka-plugin-zip to pentaho-streaming-kafka-plugin
merge from master renamed the artifact name from pentaho-streaming-kafka-plugin-zip to pentaho-streaming-kafka-plugin
… the scheduler plugin
[BACKLOG-39394] [BACKLOG-39455] - Resolving the action class moved to the scheduler plugin
Revert "[BACKLOG-37897] - Update of pentaho.xml to support email sources"
…ho/pentaho-platform into master-merge-scheduler-plugin # Conflicts: # THESE CONFLICTING FILES WERE MOVE TO THE SCHEDULER-PLUGIN PROJECT AND WERE # REMOVED FROM THIS PROJECT # scheduler/src/main/java/org/pentaho/platform/scheduler2/quartz/QuartzScheduler.java # scheduler/src/test/java/org/pentaho/platform/scheduler2/quartz/test/ComplexTriggerTest.java # user-console/src/main/java/org/pentaho/mantle/client/workspace/SchedulesPanel.java
This comment has been minimized.
This comment has been minimized.
}-*/; | ||
|
||
private native void getScheduleParams( JSONObject scheduleRequest) /*-{ | ||
$wnd.pho.getScheduleParams( scheduleRequest ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e-cuellar Nick has found an issue with this code. Please review this slack history
https://hitachivantara-eng.slack.com/archives/C01HJ874L8Z/p1703281047403969
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented Nic's changes to "pentaho-platform" as well as in the "pentaho-scheduler-plugin" @rmansoor
@@ -55,6 +55,7 @@ | |||
<groupId>org.hsqldb</groupId> | |||
<artifactId>hsqldb</artifactId> | |||
<version>${hsqldb.version}</version> | |||
<!-- <classifier>jdk8</classifier>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wseyler do you know why this change was made
@@ -134,8 +128,8 @@ | |||
</bean> | |||
<bean class="org.pentaho.platform.web.http.api.resources.EmailResource" scope="request"/> | |||
<bean class="org.pentaho.platform.web.http.api.resources.SessionResource" scope="request"/> | |||
<bean class="org.pentaho.platform.web.http.api.resources.SchedulerResource" scope="request"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove this code not comment it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rmoved this commented code @rmansoor
a0dc088
to
5a15675
Compare
[BACKLOG-39033] - Master merge into scheduler plugin
5a15675
to
feb5d47
Compare
This comment has been minimized.
This comment has been minimized.
❌ Build failed in 3h 17m 50sBuild command: mvn clean verify -B -e -Daudit -amd ⛔ Failed Tests⛈️ 2 test(s) failed:org.pentaho.platform.plugin.services.exporter.PentahoPlatformExporterTest.testExportSchedules_SchedulereThrowsException (click to expand)
org.pentaho.platform.plugin.services.importer.SolutionImportHandlerTest.testFileIsScheduleInputSource (click to expand)
Tests run: 2676, Failures: 2, Skipped: 6 Test Results Errors:Filtered log (click to expand)
ℹ️ This is an automatic message |
No description provided.