[BACKLOG-39521] Added if statement to remove username and password be… #5499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcDiamantHitachi
force-pushed
the
BACKLOG-39521
branch
from
7a71e52 to
5c146bc
Compare
This comment has been minimized.
This comment has been minimized.
MarcDiamantHitachi
force-pushed
the
BACKLOG-39521
branch
from
5c146bc to
247e2b8
Compare
This comment has been minimized.
This comment has been minimized.
✅ Build finished in 4m 42sBuild command: mvn clean verify -B -e -Daudit -amd -pl tomcat-logs❗ No tests found!ℹ️ This is an automatic message |
|
SonarQube Quality Gate
|
dcleao
reviewed
Jan 24, 2024
Comment on lines
+39
to
+44
| if ( tempString.contains( "/pentaho/api/csrf" ) || tempString.contains( "/pentaho/api/repo/files/backup" ) ) { | ||
| tempString = tempString.replaceAll( "\\?userid[^&]+%26", "" ); | ||
| tempString = tempString.replaceAll( "\\?userid[^&]+", "" ); | ||
| tempString = tempString.replaceAll( "password[^&]+%26", "" ); | ||
| tempString = tempString.replaceAll( "\\&password[^&]+", "" ); | ||
| } |
There was a problem hiding this comment.
IMO, this implementation should not have been merged as is.
Why does the filter only apply to these two URLs?
The parameter names used by RequestParameterAuthenticationFilter are configurable via the properties of the requestParameterProcessingFilter bean. Some customers may have these configured differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing printed