Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKLOG-42356] Check if the file already exists before saving #5815

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

SreejaSridhar
Copy link
Contributor

No description provided.

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@buildguy

This comment has been minimized.

Copy link
Contributor

@NJtwentyone NJtwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner implementation and simpler than previous PR - #5812

Mostly javadoc comments and unit testing not all comments are included below:

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 81.80% Coverage (33.50% Estimated after merge)
  • Duplications 0.00% Duplicated Code (3.30% Estimated after merge)

Project ID: pentaho:pentaho-platform-ce-parent

View in SonarQube

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy
Copy link
Collaborator

✅ Build finished in 23m 10s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl extensions

👌 All tests passed!

Tests run: 1565, Failures: 0, Skipped: 5    Test Results


ℹ️ This is an automatic message

@NJtwentyone
Copy link
Contributor

There are 2 high security scans issues on CodeQL PR checks, these need to addressed
Screenshot 2024-12-19 at 9 05 04 AM

Copy link
Contributor

@NJtwentyone NJtwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL PR check fails:
"2 new alerts including 2 high severity security vulnerabilities"
#5815 (comment)

@SreejaSridhar
Copy link
Contributor Author

codeQL check is failing for multiple unchanged files which are not pertained to just these PR files, "Unchanged files with check annotations"
image (1)

Not making changes to this PR as it might affect multiple files.

Copy link
Contributor

@NJtwentyone NJtwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All items were addressed.
As noted, codeql findings are unrelated to code changes in this PR - #5815 (comment)

@NJtwentyone NJtwentyone merged commit 2c60be9 into pentaho:master Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants