-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACKLOG-42356] Check if the file already exists before saving #5815
Conversation
Quality Gate failedFailed conditions |
This comment has been minimized.
This comment has been minimized.
extensions/src/main/java/org/pentaho/platform/web/http/api/resources/FileResource.java
Show resolved
Hide resolved
extensions/src/main/java/org/pentaho/platform/web/http/api/resources/FileResource.java
Outdated
Show resolved
Hide resolved
extensions/src/main/java/org/pentaho/platform/web/http/api/resources/FileResource.java
Show resolved
Hide resolved
extensions/src/main/java/org/pentaho/platform/web/http/api/resources/services/FileService.java
Outdated
Show resolved
Hide resolved
extensions/src/main/java/org/pentaho/platform/web/http/api/resources/services/FileService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaner implementation and simpler than previous PR - #5812
Mostly javadoc comments and unit testing not all comments are included below:
24e2b17
to
d3bf8e2
Compare
Analysis Details0 IssuesCoverage and DuplicationsProject ID: pentaho:pentaho-platform-ce-parent |
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
✅ Build finished in 23m 10sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl extensions 👌 All tests passed! Tests run: 1565, Failures: 0, Skipped: 5 Test Results ℹ️ This is an automatic message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL PR check fails:
"2 new alerts including 2 high severity security vulnerabilities"
#5815 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All items were addressed.
As noted, codeql findings are unrelated to code changes in this PR - #5815 (comment)
No description provided.