feat(dex): add initial metrics to dex actions #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
2788-dex-metrics-part-1
branch
from
b52cc82
to
87c66ab
Compare
conorsch
force-pushed
the
2788-dex-metrics-part-1
branch
from
87c66ab
to
e8377d0
Compare
conorsch
force-pushed
the
2788-dex-metrics-part-1
branch
from
e8377d0
to
c3aaa86
Compare
erwanor
reviewed
Aug 2, 2023
| describe_histogram!( | ||
| DEX_TRADE_DURATION, | ||
| Unit::Seconds, | ||
| "The time spent executing trades within the DEX" |
There was a problem hiding this comment.
nit: later we should change this to DEX_ARB_DURATION and make it track the end_block arbitrage operation. this way we have individual measurements for both batch execution and arb execution which are the two main lifts for the dex engine.
There was a problem hiding this comment.
Great feedback, added! Will follow up with some graphs next.
erwanor
approved these changes
Aug 2, 2023
Shipping some new dex-related metrics. Care has been taken to ensure that we are emitting Histogram, rather than Summary, data types. More info: * https://prometheus.io/docs/practices/histograms/ * https://docs.rs/metrics-exporter-prometheus/0.10.0/metrics_exporter_prometheus/struct.PrometheusBuilder.html#method.set_buckets The buckets themselves were surely need to be tweaked, but for now, I'm eager to get these new metrics onto preview, and will follow up with some visualization work. Refs #2788.
conorsch
force-pushed
the
2788-dex-metrics-part-1
branch
from
c3aaa86
to
c2c2298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping some new dex-related metrics. Care has been taken to ensure that we are emitting Histogram, rather than Summary, data types. More info:
The buckets themselves were surely need to be tweaked, but for now, I'm eager to get these new metrics onto preview, and will follow up with some visualization work.
Refs #2788.