Arkworks v0.5 #4927
Closed
Arkworks v0.5 #4927
+157
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalDerei
had a problem deploying
to
smoke-test
GitHub Actions
Failure
2 tasks
TalDerei
pushed a commit
that referenced
this pull request
Nov 18, 2024
## Describe your changes The parameter-setup crate was broken due to outdated dependencies. The options here are: 1. add this tool to the workspace 2. keep the dependencies updated instead of using workspace inheritance Option 1 is more maintainable. Even though the parameters are fixed now due to mainnet, folks may try to use this crate for debugging - the scenario that motivated this commit. To test: I followed the steps in https://guide.penumbra.zone/dev/parameter_setup to ensure we could run the parameter setup. ## Issue ticket number and link This was discovered while debugging #4927 ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > this is a dev only change
TalDerei
had a problem deploying
to
smoke-test
GitHub Actions
Failure
This was referenced Nov 19, 2024
|
closing due to circuit breaking changes identified in penumbra-zone/decaf377#109 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Upgrade arkworks dependencies to
v0.5Issue ticket number and link
References #4911
Related to penumbra-zone/decaf377#109, penumbra-zone/poseidon377#65, penumbra-zone/decaf377-rdsa#27
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: