Use Array.fromAsync polyfill (#777)

apps/extension/array-from-async.d.ts

@@ -0,0 +1 @@
+declare module 'array-from-async';

apps/minifront/array-from-async.d.ts

@@ -0,0 +1 @@
+declare module 'array-from-async';

packages/polyfills/array-from-async.d.ts

@@ -0,0 +1 @@
+declare module 'array-from-async';

packages/polyfills/package.json

@@ -19,5 +19,8 @@
     "clean": "rm -rfv dist",
     "lint": "eslint \"**/*.ts*\"",
     "test": "vitest run"
+  },
+  "dependencies": {
+    "array-from-async": "^3.0.0"
   }
 }

packages/polyfills/src/Array.fromAsync.ts

@@ -1,12 +1,15 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
-// just a type declaration for chrome's existing Array.fromAsync
-
-type ArrayWithAsync = typeof Array & {
-  fromAsync<T, U = T>(
-    arrayLike: ArrayLike<T> | AsyncIterable<T>,
-    mapfn?: (v: T, k: number) => U,
-    thisArg?: any,
-  ): Promise<U[]>;
-};
-
-export default Array as ArrayWithAsync;
+import fromAsync from 'array-from-async';
+
+type FromAsync = <T, U = T>(
+  arrayLike: ArrayLike<T> | AsyncIterable<T>,
+  mapfn?: (v: T, k: number) => U,
+  thisArg?: unknown,
+) => Promise<U[]>;
+
+type ArrayWithFromAsync = typeof Array & { fromAsync: FromAsync };
+
+if (!('fromAsync' in Array)) {
+  Object.assign(Array, { fromAsync: fromAsync as FromAsync });
+}
+
+export default Array as ArrayWithFromAsync;

packages/router/array-from-async.d.ts

@@ -1,3 +1 @@
-declare module 'array-from-async' {
-  export { default } from '@penumbra-zone/polyfills/src/Array.fromAsync';
-}
+declare module 'array-from-async';

packages/router/package.json

@@ -19,8 +19,5 @@
     "@penumbra-zone/storage": "workspace:*",
     "@penumbra-zone/transport-dom": "workspace:*",
     "@penumbra-zone/wasm": "workspace:*"
-  },
-  "devDependencies": {
-    "array-from-async": "^3.0.0"
   }
 }

packages/router/tests-setup.js

@@ -1,8 +1,5 @@
-import fromAsync from 'array-from-async';
 import { vi } from 'vitest';
 
-Array.fromAsync = fromAsync;
-
 // chrome.storage persistence middleware is run upon importing from `state/index.ts`.
 // For tests, this is problematic as it uses globals. This mocks those out.
 global.chrome = {

packages/transport-dom/array-from-async.d.ts

@@ -0,0 +1 @@
+declare module 'array-from-async';