Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: use TCT block acceleration #1716

Merged
merged 5 commits into from
Sep 4, 2024
Merged

sync: use TCT block acceleration #1716

merged 5 commits into from
Sep 4, 2024

Conversation

hdevalence
Copy link
Member

Relevant to #1576; I believe this code does the correct behavior but I've only checked that it compiles. Posting so it can get pulled into other work streams

Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: 255642e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@penumbra-zone/wasm Minor
@penumbra-zone/perspective Major
@penumbra-zone/query Major
@penumbra-zone/services Major
@penumbra-zone/storage Major
minifront Patch
@penumbra-zone/ui Patch
node-status Patch
@repo/tailwind-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hdevalence
Copy link
Member Author

Looks like the repo could disable the clippy::clone_on_copy lint

@TalDerei TalDerei marked this pull request as ready for review September 2, 2024 04:28
@TalDerei TalDerei self-requested a review September 2, 2024 04:28
Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this implementation appears to achieve parity with the core. Preliminary benchmarks indicate a sync performance improvement of approximately 60%, which aligns with our analysis here.


benchmarks:

  • mainnet
  • testnet whale seedphrase
  • ~900k blocks
  • crouton rpc

without TCT block acceleration: 285 seconds
with TCT block acceleration: 175 seconds

@TalDerei TalDerei changed the title wip: use TCT insert_block sync: use TCT block acceleration Sep 2, 2024
@TalDerei TalDerei merged commit 990291f into main Sep 4, 2024
6 checks passed
@TalDerei TalDerei deleted the use-tct-insert-block branch September 4, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants