move epoch genesis to block processor #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5bb8f9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
turbocrime
force-pushed
the
turbocrime/epoch-genesis
branch
from
7fdd103
to
b4d28ed
Compare
turbocrime
force-pushed
the
turbocrime/epoch-genesis
branch
from
b4d28ed
to
48e2df7
Compare
|
took over the draft PR and the opportunity to audit some of the database and block processor code for other instances of divergence where IDB may be performing tasks that are traditionally handled by the block processor. I think it's generally desirable to maintain a separation of concerns between different components. |
grod220
reviewed
Oct 1, 2024
grod220
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idb is presently performing epoch genesis, instead of the block processor directing idb through the process.
block processor should contain all genesis special cases.
#1719