Fix exponential string bug #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
grod220
force-pushed
the
exponential-bug-fix
branch
from
ca795b2
to
08314f2
Compare
JasonMHasperhoven
approved these changes
Sep 4, 2024
grod220
force-pushed
the
exponential-bug-fix
branch
from
08314f2
to
698619d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are doing an IBC-in, if the user selects a number sufficiently big, the notation will convert to the exponential form:
1.12e+20. This, however, is not a valid input as a coin amount for a ibc transfer message. It needs to be the full form.This PR fixes this bug by overriding the default exponential config when performing the IBC-in to ensure it does not go to the exponential form.
Related: noble-assets/noble#404