rebase #1574 getter refactor #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 38a21b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
turbocrime
force-pushed
the
turbocrime/getter-refactor
branch
from
c2e7933
to
065dac3
Compare
|
Visit the preview URL for this PR (updated for commit 38a21b4): https://penumbra-ui-preview--pr1768-turbocrime-getter-re-i1ek3ohw.web.app (expires Wed, 11 Sep 2024 19:07:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
turbocrime
force-pushed
the
turbocrime/getter-refactor
branch
from
065dac3
to
38a21b4
Compare
TalDerei
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main failed CI on merge of #1574
some commits merged using the old style getters, but it didn't trigger a merge conflict so the PR didn't prompt for a rebase.
now corrected.
https://github.com/penumbra-zone/web/compare/a7ed0ab..c2e7933