feat(ui): #1714: finish the AssetSelector UI component
#1771
Conversation
🦋 Changeset detectedLatest commit: 15b9b54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Visit the preview URL for this PR (updated for commit 15b9b54): https://penumbra-ui-preview--pr1771-1714-finish-the-asse-0se4tga0.web.app (expires Thu, 19 Sep 2024 10:08:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
…selector-ui-component
There was a problem hiding this comment.
thoughts: I personally find the popup animation with the distortion a bit wonky. However, may be worth a discussion later with Sam about preferred animation strategies.
There was a problem hiding this comment.
Agree. We should revise the animations and standardize them later
Closes #1714
Closes #1731
The result: https://penumbra-ui-preview--pr1771-1714-finish-the-asse-0se4tga0.web.app/?path=/docs/ui-library-assetselector--docs
Implements the
<AssetSelector/>,<AssetSelector.Custom/>, and<AssetSelector.ListItem/>components. The idea of separating the Custom from the default component is that, as a UI library, we want to give the users some level of control over the filtering, sorting and grouping logic in this component. The default version is also needed for the future implementation of #1773 and #1774, so it stays as simple as possible.