Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bash for submission #282

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Use bash for submission #282

wants to merge 4 commits into from

Conversation

nsheff
Copy link
Contributor

@nsheff nsheff commented Aug 17, 2020

Awhile ago I ran into an issue using looper in an environment that wasn't running on bash.

This solved the problem. I'm not sure this is what we should do, but wanted to document that if the shell isn't bash, then the config files can't use bash constructs... so we may want to think of a systematic way to handle this.

  • wait for divvy 0.7.0 (which chmod +x the written script)

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #282 into dev will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #282   +/-   ##
=======================================
  Coverage   18.06%   18.06%           
=======================================
  Files          32       32           
  Lines        4040     4040           
=======================================
  Hits          730      730           
  Misses       3310     3310           
Impacted Files Coverage Δ
looper/conductor.py 15.72% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc806c...9eeecfb. Read the comment docs.

@nsheff
Copy link
Contributor Author

nsheff commented Aug 20, 2020

See #280

Base automatically changed from dev to master August 26, 2020 12:58
@nsheff nsheff changed the base branch from master to dev March 17, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant