implement keep alive #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowflake enforces a max idle time of 4 hours for authenticated
sessions. Any queries attempted on an idle connection after 4 hours
will error with:
Authentication token has expired. The user must authenticate again.
SQLSTATE IS: 08001
The idle restriction is configurable for JDBC, but unfortunately not for
ODBC. For ODBC users, Snowflake recommends sending periodic dummy
queries to prevent the session from being idle for more than 4 hours.
This change adds a `keep_alive?` option to the Connection module. When
true, each worker in the connection pool will send a `SELECT 1` query to
Snowflake every 3 hours if no other query has been executed for that
worker. `keep_alive?` defaults to `false` so that existing users may
choose to opt in.
The Erlang meck library has been added to support unit testing odbc.
See also Snowflake's FAQ on idle connections:
https://community.snowflake.com/s/article/faq-how-long-can-my-jdbcodbc-connection-remain-idle
dustinfarris
force-pushed
the
DAPPS-303-keep-alive
branch
from
0bfc5dc to
99a0f91
Compare
|
This looks great overall. I wonder if we want to use meck to test this vs. mox which the core team supports. |
zbarnes757
approved these changes
Mar 9, 2021
|
@Ch4s3 I was thinking the same thing. I think mox will likely be better for us in the long run. |
I looked at mox initially. From my (limited) reading and experience, it looks like it is intended mainly for Elixir behaviours and not much else, but I could be mis-interpreting. In this case I'm looking to mock an Erlang lib. fwiw I tried this: Mox.defmock(Snowflex.MockODBC, for: :odbc)in test_helpers and that failed to compile: |
Ch4s3
approved these changes
Mar 9, 2021
|
Thanks for the feedback. Created #12 as a followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflake enforces a max idle time of 4 hours for authenticated
sessions. Any queries attempted on an idle connection after 4 hours
will error with:
The idle restriction is configurable for JDBC, but unfortunately not for
ODBC. For ODBC users, Snowflake recommends sending periodic dummy
queries to prevent the session from being idle for more than 4 hours.
This change adds a
keep_alive?option to the Connection module. Whentrue, each worker in the connection pool will send a
SELECT 1query toSnowflake every 3 hours if no other query has been executed for that
worker.
keep_alive?defaults tofalseso that existing users maychoose to opt in.
The Erlang meck library has been added to support unit testing odbc.
See also Snowflake's FAQ on idle connections:
https://community.snowflake.com/s/article/faq-how-long-can-my-jdbcodbc-connection-remain-idle