github issue 337, added resources block under pmm #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and also helps in maintaining QoS of pods
siddharthmakwana
requested review from
hors,
tplavcic,
nmarukovich,
ptankov,
jvpasinatto and
eleo007
as code owners
|
|
|
done via #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue 337, added resources block under pmm to limit resources like CPU and mem and this also helps maintain the QoS of pods. Currently, due to a lack of resources block under PMM, k8s won't ensure Guaranteed QoS for MongoDB pods launched via the Operator through statefulSet. This makes those pods prone to preemption.
This PR should allow QoS to be set for pods as guaranteed and also allow user to limit resources to the PMM container.