Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-872: don't restore a backup with error state #1266

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Jul 24, 2023

K8SPSMDB-872 Powered by Pull Request Badge

https://jira.percona.com/browse/K8SPSMDB-872

DESCRIPTION

Problem:
When restoring a backup with error status, a cluster is stuck in an initializing state, and the operator throws many error messages.

Cause:
The operator doesn't check if the backup has an error status before starting the restore.

Solution:
The operator should check if the backup has an error status. If so, it should set an error status to restore the object and doesn't try to start it.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label Jul 24, 2023
@pooknull pooknull marked this pull request as ready for review August 9, 2023 11:45
@pull-request-size pull-request-size bot added size/XS 0-9 lines and removed size/S 10-29 lines labels Aug 10, 2023
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service failure
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
recover-no-primary passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
storage passed
upgrade passed
upgrade-consistency passed
upgrade-sharded passed
users passed
version-service passed
We run 38 out of 38

commit: 6357d7d
image: perconalab/percona-server-mongodb-operator:PR-1266-6357d7de

@hors hors merged commit 8483d1b into main Aug 15, 2023
10 checks passed
@hors hors deleted the dev/K8SPSMDB-872 branch August 15, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants