-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-1002: add crd preferer primary node #1629
Conversation
021f16e
to
588c616
Compare
46d7983
to
d5c210e
Compare
Hi @sergelogvinov, thank you for your contribution. This looks good but I want to test these changes before approving. @hors if everything is OK, are you OK with including this to v1.18.0? I only have doubts about the new field name |
The name primaryPreferTagSelector reminds me of the Kubernetes naming style - Prefer, similar to the affinity preference selector, and TagSelector, resembling the NodeSelector. The term primary is also a common role associated with databases. Regarding Would you mind asking your colleagues for their thoughts on this? I can change it at any time. |
@sergelogvinov @egegunes @hors I tested this PR and everything is ok. The field name is also good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergelogvinov, please add a new field to https://github.com/percona/percona-server-mongodb-operator/blob/main/deploy/cr.yaml and comment it by default. We use this file as an example, so all fields should be present.
Add crd parameter to prefer primary node in cluster.
9c3717a
a96a5e2
to
9c3717a
Compare
done |
commit: 9c3717a |
@sergelogvinov thank you for your contribution. We will include this improvement in the next PSMDBO release (1.18.0). |
Add crd parameter to prefer primary node in cluster.
CHANGE DESCRIPTION
Problem:
K8SPSMDB-1002: The ability to change the primary node through the operator
Cause:
During the planned zone switchover process, the only way to change the primary node is to scale down the operator, adjust the node priority, and then scale the operator back up.
Solution:
CRD changes:
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability
Configuring member votes and priorities
- already exists)