-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-1133: Allow overriding member priorities #1689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echo "checking member priorities" | ||
run_mongo \ | ||
"rs.conf().members.map(m => m.priority)" \ | ||
"databaseAdmin:databaseAdmin123456@${cluster}-rs0.${namespace}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
Suggested change
"databaseAdmin:databaseAdmin123456@${cluster}-rs0.${namespace}" \ | |
"databaseAdmin:databaseAdmin123456@${cluster}-rs0.${namespace}" \ |
"rs.conf().members.map(m => m.priority)" \ | ||
"databaseAdmin:databaseAdmin123456@${cluster}-rs0.${namespace}" \ | ||
| egrep -v 'I NETWORK|W NETWORK|F NETWORK|Error saving history file|Percona Server for MongoDB|connecting to:|Unable to reach primary for set|Implicit session:|versions do not match|Error saving history file:' \ | ||
> ${tmp_dir}/priorities.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
Suggested change
> ${tmp_dir}/priorities.json | |
>${tmp_dir}/priorities.json |
pull-request-size
bot
added
size/XL
500-999 lines
and removed
size/L
100-499 lines
labels
Oct 30, 2024
commit: 82c2118 |
egegunes
requested review from
tplavcic,
nmarukovich,
ptankov,
jvpasinatto,
eleo007,
hors,
inelpandzic and
pooknull
as code owners
October 31, 2024 05:51
hors
approved these changes
Nov 5, 2024
inelpandzic
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
There's no way for users to directly set priorities to replset members.
Solution:
Use
replsetOverrides
to set priorities.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability