PT-2241 - fix(pt-online-schema-change): using --skip-check-slave-lag multiple times does not work as expected

[sgjr]

using --skip-check-slave-lag multiple times does not work as expected.

• The contributed code is licensed under GPL v2.0
• Contributor Licence Agreement (CLA) is signed
• util/update-modules has been ran
• Documention updated
• Test suite update

How to reproduce?

I have three slaves, slave01-03, and slave03 has replication delay. When using the --skip-check-slave-lag option of pt-online-schema-change to skip the replication delay check for slave02 and slave03, it still waits for slave03 to catch up.

pt-online-schema-change --user=ddl_user --password=xxxxx --host=$host   P=3306,D=test,t=t6 --max-lag=1  --max-load="Threads_running=500" --critical-load="Threads_running=2048" --alter-foreign-keys-method=rebuild_constraints --no-check-unique-key-change --chunk-size=1000 --alter 'add column col052305 varchar(20) not null default "abc"'     --skip-check-slave-lag h=$slave02_host,P=3306  --skip-check-slave-lag h=$slave03_host,P=3306  --execute

[it-percona-cla]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sgjr
❌ caopeng

---

caopeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[svetasmirnova]

Please add test cases for this situation. You will find a how-to in the Contribution guide and examples in the t/pt-online-schema-change directory.

[svetasmirnova]

Updated PR header, so all updates are linked to the bug report.

[sgjr]

Please add test cases for this situation. You will find a how-to in the Contribution guide and examples in the t/pt-online-schema-change directory.

The test cases has been added. But I can't modify my branch name. Do I need to create a new standard branch and resubmit the merge request?

[svetasmirnova]

Thank you, I will review your changes.

No need to rename the branch: automation work with commit messages and PR subject.

[svetasmirnova]

Please apply the requested changes.

[EvgeniyPatlan]

LGTM 👍

[svetasmirnova]

@sgjr your PR is technically approved but we cannot accept it yet due to CLA issue:

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sgjr
x caopeng
caopeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Could you please ask caopeng to sign up for a GitHub account with the address, used for the commit, and sign the license?

Thank you!

[Aleksa-del]

Hello, @sgjr ! Thank you for your contributions! We would like to send you a gift from Percona. Please, contact us at [email protected].