-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PT-2241 - fix(pt-online-schema-change): using --skip-check-slave-lag multiple times does not work as expected #622
Conversation
…slave-lag multiple times does not work as expected.
caopeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases for this situation. You will find a how-to in the Contribution guide and examples in the t/pt-online-schema-change directory.
Updated PR header, so all updates are linked to the bug report. |
The test cases has been added. But I can't modify my branch name. Do I need to create a new standard branch and resubmit the merge request? |
Thank you, I will review your changes. No need to rename the branch: automation work with commit messages and PR subject. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply the requested changes.
fix():reset the delay on replicas Co-authored-by: Sveta Smirnova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@sgjr your PR is technically approved but we cannot accept it yet due to CLA issue:
Could you please ask caopeng to sign up for a GitHub account with the address, used for the commit, and sign the license? Thank you! |
Hello, @sgjr ! Thank you for your contributions! We would like to send you a gift from Percona. Please, contact us at [email protected]. |
using
--skip-check-slave-lag
multiple times does not work as expected.How to reproduce?