PT-2236 - pt-secure-collect, pt-pg-summary do not follow PT standard #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for option --version - Redirected UsageWriter to os.Stdout for kingpin, so --version output goes to STDOUT, not to STDERR - Adjusted text, printed by the --version flag - Added test cases to check how --version flag works - Adjusted test cases, so they use TOOLNAME constant
…for option --version Run go mod tidy as requested by Artem Gavrilov
…for option --version Renamed const TOOLNAME to toolname to follow Go coding standards
artemgavrilov
approved these changes
Jul 28, 2023
egegunes
approved these changes
Jul 31, 2023
svetasmirnova
deleted the
PT-2236_pt-secure-collect_pt-pg-summary_do_not_follow_PT_standard_for_option_--version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for option --version
Redirected UsageWriter to os.Stdout for kingpin, so --version output goes to STDOUT, not to STDERR
Adjusted text, printed by the --version flag
Added test cases to check how --version flag works
Adjusted test cases, so they use TOOLNAME constant
The contributed code is licensed under GPL v2.0
Contributor Licence Agreement (CLA) is signed
util/update-modules has been ran
Documention updated
Test suite update