Pt 2247 #686
Merged
Pt 2247 #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) OR instead and in the if line 2042 2) evaluate array create_user if it has some value 3) filter out the user creation in Mariadb inside the Grants
- Use of VIA - Use of USING - Incompatible syntax with MySQL - ADD IF NOT EXISTS - convert the script to us AS to maintain the hash as they are Add a parameter --convert-MariaDB as parameter (default false)
correct an IF condition removed a delete action on mysql.user. Always use DROP not delete
…2_password plugin. The problem is that when caching_sha2_password is used the character utilised in the string may be invalid for MySQL itself to process during creation time. Given that the password must be converted to HEX and then pushed as binary using the AS <bin password> format
Pt 2247 1212
…n alternative to the conversion Param --print_identified_with_as_hex
Adding the option to use in session print_identified_with_as_hex as a…
…print_identified_with_as_hex
Adding a small check if we have MariaDB in order to prevent usage of …
svetasmirnova
requested changes
Oct 6, 2023
svetasmirnova
requested changes
Oct 6, 2023
bin/pt-show-grants
Outdated
| @@ -2039,25 +2039,52 @@ sub main { | |||
|
|
|||
| # If MySQL 5.7.6+ then we need to use SHOW CREATE USER | |||
| my @create_user; | |||
| if (( VersionCompare::cmp($version, '5.7.6') >= 0 ) && | |||
| if (( VersionCompare::cmp($version, '5.7.6') >= 0 ) || | |||
There was a problem hiding this comment.
With "||" this expression is always true.
bin/pt-show-grants
Outdated
|
|
||
| When set it convert some of the proprietary MariaDB syntax into valid MySQL form | ||
|
|
||
| =item --print_identified_with_as_hex |
There was a problem hiding this comment.
According to the user manual at https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_print_identified_with_as_hex:
Hash values that do not contain unprintable characters still display as regular string literals, even with this variable enabled.
Do we really need this option or checking for correct MySQL version is enough?
- Removed option print_identified_with_as_hex, because it was already implemented in the PT-2190 fix - Simplified patch - Kept CREATE USER/ALTER USER sequence and extra DELETE from mysql.user table - Added test case
|
@Tusamarco I changed your PR: simplified a few things, removed the option --print_identified_with_hex (made it default and only behavior), and added a test case. Please review and see if you agree with the changes. |
svetasmirnova
approved these changes
May 20, 2024
EvgeniyPatlan
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@svetasmirnova please check and review also https://jira.percona.com/browse/PT-2247