PT-2109 - pt-mysql-summary throws an error when using sql_mode="ANSI_QUOTES" #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…QUOTES" - Fixed issues still visible with SQL mode ANSI_QUOTES - Added test cases for this mode
saikumar-vs
reviewed
Nov 2, 2023
t/pt-mysql-summary/pt-2109.t
Outdated
Comment on lines
44
to
45
| if (!$has_keyring_plugin) { | ||
| plan skip_all => 'Keyring plugins are not enabled.'; |
There was a problem hiding this comment.
Do we really need to skip this test if "Keyring" plugin is not enabled?
There was a problem hiding this comment.
Good point! Removed.
EvgeniyPatlan
approved these changes
Nov 2, 2023
…QUOTES" - Removed keyring plugin check in the beginning of the test, because reported error would show up even on servers that do not have keyring plugin installed. Same applies to wsrep_on check and Percona Server features checks. - Removed temporary dir setup, because not needed for this test.
saikumar-vs
approved these changes
Nov 2, 2023
svetasmirnova
deleted the
PT-2109_pt-mysql-summary_throws_an_error_when_using_sql_mode=ANSI_QUOTES
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…QUOTES"
Fixed issues still visible with SQL mode ANSI_QUOTES
Added test cases for this mode
The contributed code is licensed under GPL v2.0
Contributor Licence Agreement (CLA) is signed
util/update-modules has been ran
Documentation updated
Test suite update