Update pt-mysql-summary #839
Conversation
Changed the deprecated variable name tx_isolation to transaction_isolation
|
|
|
Thank you for your contribution. You changed the auto-generated code. The fix should go into the lib/bash/report_mysql_info.sh file. Please fix, then run Also, pt-mysql-summary should support older versions, so we need a condition here. Also, tests should be adjusted for 5.7.20+ and elder versions. |
|
hello @svetasmirnova I updated the code with mysql version checks it is working fine as I run it. I am not aware of the regression tests, could you please infer me how to do it.
|
- Reversed condition, so default is transaction_isolation, not tx_isolation - Removed extra variable: we have variable $version, defined before - Fixed test cases
|
Thank you for the changes. I added a few more. Please review them and let us know if you agree. |
I agree with the changes, and thank you for adding it. |
Changed the deprecated variable name tx_isolation to transaction_isolation
"
transaction_isolationwas added in MySQL 5.7.20 as an alias fortx_isolation, which is now deprecated and is removed in MySQL 8.0. Applications should be adjusted to usetransaction_isolationin preference totx_isolation"reference : https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_tx_isolation