-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #133
Update README.md #133
Conversation
Performance test results: |
README.md
Outdated
This datafile is created and managed by Postgres, the only requirement is that postgres should be able to write to the specified path. | ||
|
||
This setup is intended for developmenet, and stores the keys unencrypted in the specified data file. | ||
**Note: This setup is intended for development and stores the keys unencrypted in the specified data file.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note should be at the file provider function, not after set master key.
README.md
Outdated
"provider": "file", | ||
"datafile": "/tmp/pgkeyring" | ||
} | ||
**Example**: Add a `File` key provider and name it `file-vault`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we have a Vault provider, the file-vault
name looks a bit confusing.
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Co-authored-by: Andrew Pogrebnoi <[email protected]>
Adjust the readme to reflect changes made to set up key providers and master key.