A function to get the current master key info. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit adds tde_master_key_info() function that returns the information about the master key for the database. select * from tde_master_key_info(); master_key_name | key_provider_name | key_provider_id | master_key_internal_name | master_key_version | key_createion_time -----------------+-------------------+-----------------+--------------------------+--------------------+------------------------------- test-master-key | file-two | 1 | test-master-key_1 | 1 | 2024-03-25 18:07:13.131834+05 (1 row)
dutow
reviewed
Mar 25, 2024
src/catalog/tde_master_key.c
Outdated
| @@ -31,7 +32,7 @@ | |||
|
|
|||
| #define DEFAULT_MASTER_KEY_VERSION 1 | |||
|
|
|||
| typedef struct TdeMasterKeySharedState | |||
| typedef struct TdeMasterKeySharedState | |||
There was a problem hiding this comment.
unnecessary formatting change?
There was a problem hiding this comment.
That was un-intentional. Thanks for pointing out. Fixed
src/catalog/tde_master_key.c
Outdated
| GenericKeyring *keyring; | ||
|
|
||
| /* Build a tuple descriptor for our result type */ | ||
| if (get_call_result_type(fcinfo, NULL, &tupdesc) != TYPEFUNC_COMPOSITE) |
There was a problem hiding this comment.
Also inconsistent indentation in this function
| @@ -21,6 +21,9 @@ SELECT amname FROM pg_class INNER JOIN pg_am ON pg_am.oid = pg_class.relam WHERE | |||
| SELECT pgtde_is_encrypted('test_enc'); | |||
| SELECT pgtde_is_encrypted('test_norm'); | |||
|
|
|||
| SELECT key_provider_id, key_provider_name, master_key_name | |||
There was a problem hiding this comment.
Can we also have a test with the extension enabled, but without anything configured? (no provider / master key added)
| (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), | ||
| errmsg("function returning record called in context that cannot accept type record"))); | ||
|
|
||
| master_key = GetMasterKey(); |
There was a problem hiding this comment.
GetMasterKey() throws an ERROR when it can't return the master key. I have still added a check here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit adds tde_master_key_info() function that returns the information about the master key for the database.
select * from tde_master_key_info();
master_key_name | key_provider_name | key_provider_id | master_key_internal_name | master_key_version | key_createion_time
-----------------+-------------------+-----------------+--------------------------+--------------------+-------------------------------
test-master-key | file-two | 1 | test-master-key_1 | 1 | 2024-03-25 18:07:13.131834+05
(1 row)