PG-952: Handle non existent principal key in tde_heap #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeforall
requested changes
Sep 19, 2024
src/pg_tde_event_capture.c
Outdated
| if (principal_key == NULL) | ||
| { | ||
| ereport(ERROR, | ||
| (errmsg("failed to retrieve principal key"))); |
There was a problem hiding this comment.
Overall, it looks good. However, the error message should be more descriptive and suggestive. Maybe an error hint should be added as well to let users know how they can solve this issue, like suggesting they create a principal key.
There was a problem hiding this comment.
maybe, I just copied the error message we display for tde_heap_basic
Previously when the database had no principal key, tde_heap simply igored it and created a table without encryption. With this change, it reports an error instead.
dAdAbird
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when the database had no principal key, tde_heap simply igored it and created a table without encryption.
With this change, it reports an error instead.