Refactor internal/principal key LWLocks #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, several flaws existed in the lock protection of the Internal and Principal keys. Such as double locking, insufficient locking while rotating the principal key and internal key retrieval from the disk. We also had two locks guarding the same actions, which in 90% of cases were locked and unlocked together. This commit tries to address all these issues. For: https://perconadev.atlassian.net/browse/PG-858
codeforall
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, several flaws existed in the lock protection of the Internal and Principal keys. Such as double locking, insufficient locking while rotating the principal key and internal key retrieval from the disk. We also had two locks guarding the same actions, which in 90% of cases were locked and unlocked together. This commit tries to address all these issues.
For: https://perconadev.atlassian.net/browse/PG-858