Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sequential scan performance tests #303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added sequential scan performance tests #303

wants to merge 1 commit into from

Conversation

dutow
Copy link
Collaborator

@dutow dutow commented Oct 7, 2024

No description provided.

@dutow dutow marked this pull request as draft October 7, 2024 19:20
@dutow dutow force-pushed the seqreadtests branch 2 times, most recently from 3e01b1d to d6f35ad Compare October 7, 2024 19:36
@dutow
Copy link
Collaborator Author

dutow commented Oct 7, 2024 

Sequential scan read times
==========================
HEAP: 1172.451
TDE: 1320.662
TDE_BASIC: 1980.203

@dutow dutow marked this pull request as ready for review October 7, 2024 19:55
dAdAbird
dAdAbird reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@dAdAbird dAdAbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But it'd be nice to have a % overhead next to tde and tde_basic. Something like:

Sequential scan read times
==========================
HEAP: 1172.451
TDE: 1320.662 (+11.22%)
TDE_BASIC: 1980.203 (+40.80%)

@dAdAbird
Copy link
Member

dAdAbird commented Oct 8, 2024

And maybe a number of rows in test data - just to have a bulpark estimation in mind when reading results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dAdAbird dAdAbird dAdAbird left review comments

@codeforall codeforall Awaiting requested review from codeforall

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dutow @dAdAbird