-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG-1072: Fix major event trigger issues #307
Conversation
dutow
commented
Oct 9, 2024
- Create table always checked the principal key and tried to create it, event when we didn't try to create a tde_heap table
- Alter table wasn't handled, and because of this changing a table to tde_heap access method didn't result in an encrypted table.
- defaut_table_access_method wasn't handled, and because of this, creating a table using that also resulted in a non encrypted table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall just a couple of printf leftovers
src/pg_tde_event_capture.c
Outdated
fprintf(stderr, "ALTEEEER\n"); | ||
fprintf(stderr, "ALTEEEER\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug leftovers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fixed.
src/pg_tde_event_capture.c
Outdated
{ | ||
AlterTableCmd *cmd = (AlterTableCmd *) lfirst(lcmd); | ||
if(cmd->subtype == AT_SetAccessMethod && strcmp(cmd->name, "tde_heap")==0) { | ||
fprintf(stderr, "TO ENCRYPTED\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug leftovers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fixed.
* Create table always checked the principal key and tried to create it, event when we didn't try to create a tde_heap table * Alter table wasn't handled, and because of this changing a table to tde_heap access method didn't result in an encrypted table. * defaut_table_access_method wasn't handled, and because of this, creating a table using that also resulted in a non encrypted table.