Use a custom prefix instead of a hardcoded serverid for keys #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, key names no longer contain the hardcoded serverid, but instead use a user specifiable and optional prefix. With default settings the prefix is empty, and we generate key names in the format of "<name>-<version>". With a non empty prefix set, the format changes to "<prefix>-<name>-<version>". The test suite is also modified, so that the existing TAP test uses a custom prefix, and the SQL tests use an empty prefix, to test both cases.
dAdAbird
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, key names no longer contain the hardcoded serverid, but instead use a user specifiable and optional prefix.
With default settings the prefix is empty, and we generate key names in the format of "-". With a non empty prefix set, the format changes to "--".
The test suite is also modified, so that the existing TAP test uses a custom prefix, and the SQL tests use an empty prefix, to test both cases.