Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding note on performance_schema_max_digest_length #1153

Merged
merged 5 commits into from
May 20, 2024

Conversation

nethalo
Copy link
Contributor

@nethalo nethalo commented Sep 27, 2023

No description provided.

@@ -206,6 +206,9 @@ To use *Performance Schema*, set the variables below.
| [`performance-schema-consumer-statements-digest`][perfschema-consumer-statements-digest] | `ON` | Configures the `statements-digest` consumer.
| [`innodb_monitor_enable`][sysvar_innodb_monitor_enable] | all | Enables InnoDB metrics counters.

!!! caution alert alert-warning "Important"
When dealing with long queries, increasing the value of the variable [performance_schema_max_digest_length](https://dev.mysql.com/doc/refman/8.0/en/performance-schema-system-variables.html#sysvar_performance_schema_max_digest_length) will avoid having query examples truncated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also have --max-query-length flag in pmm-admin add commands to limit query length in QAN, where -1 value is no limit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that is a pmm-admin config parameter and not a MySQL variable. I'd defer that to be added by the doc team

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

than it won't be true in context of PMM. @rnovikovP PTAL ^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, To have queries with full length it's 2 parameters need to be tuned:

  1. MySQL perf schema ^
  2. PMM flag for the length

If both of them are aligned - then the user will see the full query (most likely .. still can be a problem with veeeeryyyy long queries )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a PR for a note explaining a Performance Schema modification. Please make another one for non-related information (non-mysql modification) @rnovikovP

@@ -206,6 +206,9 @@ To use *Performance Schema*, set the variables below.
| [`performance-schema-consumer-statements-digest`][perfschema-consumer-statements-digest] | `ON` | Configures the `statements-digest` consumer.
| [`innodb_monitor_enable`][sysvar_innodb_monitor_enable] | all | Enables InnoDB metrics counters.

!!! caution alert alert-warning "Important"
When dealing with long queries, increasing the value of the variable [performance_schema_max_digest_length](https://dev.mysql.com/doc/refman/8.0/en/performance-schema-system-variables.html#sysvar_performance_schema_max_digest_length) will avoid having query examples truncated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

than it won't be true in context of PMM. @rnovikovP PTAL ^

@igroene igroene requested a review from a team as a code owner May 20, 2024 14:57
@BupycHuk BupycHuk merged commit 56f8466 into percona:main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants