Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-13025 - Upgrade changes #1316
base: PMM3_Beta
Are you sure you want to change the base?
PMM-13025 - Upgrade changes #1316
Changes from 12 commits
6937dcc
ae71bc9
d2b2ae0
6ae1b0d
2200f16
535e998
1a50c28
a339810
a6f0310
070d440
203e517
35e7c0c
73758bd
acd3b78
525e5b5
2f969b9
417f6cf
c5dab98
d873fea
7a222f1
ffab19a
1166b7e
634b8f2
afaab30
37556c0
6ac3352
876052b
7b1d084
9858df4
600510f
492950d
edec715
c264596
8f4fff3
027e5ca
cd99f55
83dd6bc
6529079
cf498dc
53ad24f
66f85b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make it
v3
like in other repos.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BupycHuk , yes, I was planning to rename main to
2.x
and PMM3-branch to3.x
after GA, when PMM-3-branch becomes main. Or shall we do this when we move the doc repo to the pmm code repo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we support upgrade only from the latest PMM 2, so I think we can drop it from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnovikovP should we deprecate Backup in PMM or we keep supporting it until SEP integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this block duplicates file below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should recommend to do it as the first step to have shorter PMM down period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, @BupycHuk. I. have made this change in the
docs/pmm-upgrade/upgrade_from_ppm_2.md
topic. This is the originanting topic, which got separated into individual ones. I have deleted it now as it only duplicates content now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to mention that environment variables were changed between PMM 2 and PMM 3. @catalinaadam @idoqo do we have list somewhere public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BupycHuk , Added a section in the Environment variabled topic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to expand that. have you checked this doc https://github.com/percona/pmm/blob/v3/docs/process/v2_to_v3_environment_variables.md ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop it for V3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is below section about upgrading from PMM 1, I think we can drop it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted duplicate topic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in examples we should use PMM 3 versions. For PMM 3 package name is pmm-client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the packages do not exist yet, but they are anticipated to be like that.