-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to buf schema v2 and move api related tasks to dedicated Makefile #3176
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3176 +/- ##
==========================================
+ Coverage 43.32% 43.34% +0.02%
==========================================
Files 399 399
Lines 41654 41654
==========================================
+ Hits 18046 18056 +10
+ Misses 21590 21580 -10
Partials 2018 2018
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, but I'm wondering if it is really worth to contribute such a change to v2 versus v3?
After we release 2.43.0, the whole team should completely switch their focus to getting v3 out the door.
I can provide same changes for |
OK, there is seemingly no harm for v2, so let's do both :) Thanks for contributing, bro! |
PMM-7
Link to the Feature Build: SUBMODULES-0
This PR migrates
buf
configuration to v2. It allowed to move allapi
related tasks to dedicated Makefile.P.S. I was trying to find a way to use some plugins only for part of the modules, but unfortunately it's not possible for now.
https://buf.build/docs/migration-guides/migrate-v2-config-files
Same for PMM v3: #3178