Upgrade eslint-plugin-jsdoc to support Node.js 20 #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[email protected], required by @grafana/toolkit, only supports Node.js up to version 17. This PR upgrades eslint-plugin-jsdoc in order to support latest Node.js LTS (version 20) and updates the GitHub action workflows to use Node.js 20. Signed-off-by: Andreas Gerstmayr <[email protected]>
andreasgerstmayr
force-pushed
the
upgrade-eslint-plugin-jsdoc
branch
from
9906a4a
to
7ef47a2
Compare
|
UI tests on latest Grafana fail, they need to be upated to match the UI of the latest Grafana version. |
|
@sfeifer this one on your radar? |
|
@natoscott Yep. I am currently working on the plugin to be up to date with grafana 10.2.6. As grafana latest is grafana 11, getting those UI tests working is not high priority now, but it is in the backlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected], required by @grafana/toolkit, only supports Node.js up to version 17. This PR upgrades eslint-plugin-jsdoc in order to support latest Node.js LTS (version 20).