Skip to content

Commit

Permalink
Some minor performance tweaks, thanks to cppcheck
Browse files Browse the repository at this point in the history
  • Loading branch information
@pcolby
pcolby committed Jul 13, 2016
1 parent f77d840 commit 898ee68
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions include/pcp-cpp/metric_description.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ struct metric_description {
metric_description(const std::string &metric_name,
const atom_type_type type,
const semantic_type semantic,
const pmUnits units,
const pmUnits &units,
instance_domain * const domain = NULL,
const std::string &short_description = std::string(),
const std::string &verbose_description = std::string(),
Expand Down Expand Up @@ -183,7 +183,7 @@ class metric_cluster : public std::map<item_id_type, metric_description> {
const std::string &metric_name,
const atom_type_type type,
const semantic_type semantic,
const pmUnits units,
const pmUnits &units,
const metric_flags flags = static_cast<metric_flags>(0),
instance_domain * const domain = NULL,
const std::string &short_description = std::string(),
Expand Down Expand Up @@ -217,7 +217,7 @@ class metric_cluster : public std::map<item_id_type, metric_description> {
const std::string &metric_name,
const atom_type_type type,
const semantic_type semantic,
const pmUnits units,
const pmUnits &units,
instance_domain * const domain,
const metric_flags flags = static_cast<metric_flags>(0),
const std::string &short_description = std::string(),
Expand Down Expand Up @@ -251,7 +251,7 @@ class metric_cluster : public std::map<item_id_type, metric_description> {
const std::string &metric_name,
const atom_type_type type,
const semantic_type semantic,
const pmUnits units,
const pmUnits &units,
instance_domain * const domain = NULL,
const std::string &short_description = std::string(),
const std::string &verbose_description = std::string(),
Expand Down Expand Up @@ -339,7 +339,7 @@ class metrics_description : public std::map<cluster_id_type, metric_cluster> {
const std::string &metric_name,
const atom_type_type type,
const semantic_type semantic,
const pmUnits units,
const pmUnits &units,
const metric_flags flags,
instance_domain * const domain = NULL,
const std::string &short_description = std::string(),
Expand Down Expand Up @@ -384,7 +384,7 @@ class metrics_description : public std::map<cluster_id_type, metric_cluster> {
const std::string &metric_name,
const atom_type_type type,
const semantic_type semantic,
const pmUnits units,
const pmUnits &units,
instance_domain * const domain,
const metric_flags flags,
const std::string &short_description = std::string(),
Expand Down Expand Up @@ -429,7 +429,7 @@ class metrics_description : public std::map<cluster_id_type, metric_cluster> {
const std::string &metric_name,
const atom_type_type type,
const semantic_type semantic,
const pmUnits units,
const pmUnits &units,
instance_domain * const domain = NULL,
const std::string &short_description = std::string(),
const std::string &verbose_description = std::string(),
Expand Down
2 changes: 1 addition & 1 deletion include/pcp-cpp/pmda.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1339,7 +1339,7 @@ class pmda {
stream << std::endl;
}
for (std::map<domain_id_type, const instance_domain *>::const_iterator indom = instances.begin();
indom != instances.end(); indom++)
indom != instances.end(); ++indom)
{
for (instance_domain::const_iterator instance = indom->second->begin();
instance != indom->second->end(); ++instance)
Expand Down

0 comments on commit 898ee68

Please sign in to comment.