Skip to content

Commit

Permalink
pmieconf: move test_action from primary into a separate group
Browse files Browse the repository at this point in the history
Problem with using primary is that it is automatically enabled
as part of the primary pmie startup and thats not whats needed
for this diagnostic rule.

Resolves Red Hat BZ #2223348
  • Loading branch information
natoscott committed Jul 18, 2023
1 parent 84be245 commit e97d64c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/pmieconf/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ perdisk/GNUmakefile
pernetif/GNUmakefile
power/GNUmakefile
primary/GNUmakefile
testing/GNUmakefile
zeroconf/GNUmakefile
pmieconf
pmieconf.static
Expand Down
2 changes: 1 addition & 1 deletion src/pmieconf/GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ include $(TOPDIR)/src/include/builddefs
include $(TOPDIR)/src/libpcp/src/GNUlibrarydefs

MKFILE_SUBDIRS = cpu entropy filesys memory network percpu perdisk pernetif \
power global primary zeroconf
power global primary testing zeroconf
SUBDIRS = $(MKFILE_SUBDIRS)

CMDTARGET = pmieconf$(EXECSUFFIX)
Expand Down
2 changes: 1 addition & 1 deletion src/pmieconf/primary/localdefs
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ALL_RULES = pmda_status test_actions
ALL_RULES = pmda_status
LOCAL_RULES = $(ALL_RULES)
2 changes: 2 additions & 0 deletions src/pmieconf/testing/localdefs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ALL_RULES = test_actions
LOCAL_RULES = $(ALL_RULES)
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# --- DO NOT MODIFY THIS FILE --- see pmieconf(5)
#

rule primary.test_actions
rule testing.test_actions
default = "$rule$"
predicate = "hinv.ncpu > 0"
enabled = no
Expand Down

0 comments on commit e97d64c

Please sign in to comment.