Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add diversity note to contributing.md and other small updates #1795

Merged

Conversation

natoscott
Copy link
Member

No description provided.

Copy link
Member

@kmcdonell kmcdonell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... other than the respond in 24 hrs obligation 😊

@natoscott
Copy link
Member Author

LGTM ... other than the respond in 24 hrs obligation 😊

Oh yeah, good point - I left that as-is ... is it time for an update? 48hrs be better? 2/3 business days? Other? Thanks.

@christianhorn
Copy link
Collaborator

I wonder if projects can get away without referring to a time for initial assessment, but "reasonable time". Feels a bit like ticking clock otherwise.
Reporters are probably also setting time expectations, which might or might not fit the projects expectations.
LGTM (also if sticking with 24 or 48 hours for first assessment).

Copy link
Contributor

@jasonk000 jasonk000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, agree with other comments!

@kmcdonell
Copy link
Member

I think "within 3 business days" for initial response is both reasonable and matches what we've been able to deliver for the most part for almost 30 years. Given the maturity of the code, we're unlikely to be seeing any "mission-critical" issues that would demand a more expeditious response.

@natoscott
Copy link
Member Author

Thanks all - let's go with 3 business days.

@natoscott natoscott merged commit adc53b7 into performancecopilot:main Aug 17, 2023
19 checks passed
@natoscott natoscott deleted the doc-update-contributing branch August 17, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants