Fix unreliable tests in configure.ac
#2111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two tests should not rely on whether the compiler emitted warnings, but should instead rely on whether the compilation failed. For the scandir() test, with some combination of CFLAGS, the compiler may emit some warnings, failing the test, but in reality the scandir() call must use `const struct dirent *' for the callbacks.
Some distros may regenerate the configure script. autoreconf will fail if the description in these two AC_DEFINE_UNQUOTED macros are empty: - PM_PAD_RESULT - PM_PAD_TIMESPEC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests in
configure.acshould not rely on whether the compiler emitted warnings, but should instead rely on whether the compilation failed. Unintended warnings (triggered by certain combination of CFLAGS) emitted by compiler will disrupt the test result, resulting in FTBFS.For the
scandir()test, with some combination of CFLAGS, the compiler may emit some warnings, failing the test, but in reality thescandir()call must useconst struct dirent *for the callbacks.