Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JavaScript Style Standard and CI #97

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Add JavaScript Style Standard and CI #97

merged 8 commits into from
Oct 5, 2023

Conversation

mfleader
Copy link
Contributor

@mfleader mfleader commented Sep 27, 2023 •
edited
Loading

  • Add CI to check that JavaScript code style is formatted to project standard.
  • Apply JavaScript code style formatting to all JavaScript files.
  • Document how to apply style formatting.

Prettier is used to check and format JavaScript style. I modified their default configuration to use a tab width of two spaces.

I removed the Node JS engine version declaration in the package dependency configuration. I will be able to better determine an appropriate version on the unit test issue.

@mfleader mfleader added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 27, 2023
@mfleader mfleader self-assigned this Sep 27, 2023
@mfleader mfleader marked this pull request as ready for review September 28, 2023 19:39
k-rister
k-rister requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@k-rister k-rister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to say that all the formatting changes to the JS code itself need to be ACKed by @atheurer since that is overwhelmingly authored by him.

.github/workflows/cdm-ci.yaml Outdated Show resolved Hide resolved
.github/workflows/faux-cdm-ci.yaml Show resolved Hide resolved
k-rister
k-rister requested changes Sep 28, 2023
View reviewed changes
.github/workflows/cdm-ci.yaml Outdated Show resolved Hide resolved
atheurer
atheurer requested changes Oct 4, 2023
View reviewed changes
queries/cdmq/.prettierrc.toml Outdated Show resolved Hide resolved
queries/cdmq/package.json Outdated Show resolved Hide resolved
@mfleader mfleader requested a review from atheurer October 4, 2023 22:52
@mfleader mfleader merged commit 6fcf8d9 into master Oct 5, 2023
139 checks passed
@k-rister k-rister deleted the add-style branch October 5, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheurer atheurer atheurer approved these changes

@k-rister k-rister k-rister approved these changes

Assignees

@mfleader mfleader

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfleader @atheurer @k-rister