Graceful error handling of when PCIe has no numa and mv-params has "cpu_pin" option #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
For some system, e.g AMD, we can define 0, 1, 2 or 4 NUMA nodes per socket. In the case that was 0 (whole flat memory layout for both sockets), "cat /sys/class/net/ens2f0np0/device/numa_node" returns "-1" . This is the normal behavior per https://access.redhat.com/discussions/4490711.
Now if the uperf CLI has the "cpu_pin" option to indicate pinning CPUs to same numa as the NIC in-use, the subsequent code ends up blindly invoked "taskset --cpu_list -1"
Solution:
Add a snippet to detect cpu_list = -1 and uperf CLI has "cpu_pin", and error out the run gracefully. The user must remove the "cpu_pin" option from the mv-params when running on host w/o NUMA.