Add multibench support to all-in-one json #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@k-rister could you restore self-hosted runners please? |
done |
k-rister
reviewed
Sep 13, 2023
rafaelfolco
force-pushed
the
all-in-one-multibench
branch
from
6227b4f
to
f545e2f
Compare
k-rister
previously approved these changes
Sep 13, 2023
rafaelfolco
force-pushed
the
all-in-one-multibench
branch
2 times, most recently
from
bcbc33e
to
d058e8c
Compare
|
oops found one more dup that needs to be resolved. |
Add benchmarks block to identify bench ids. The blockbreaker utility extracts the benchmark from the runfile and processes multibench config. The mv-params for multibench is extracted from the 'benchmarks' block. To keep backwards compatibility with the single bench mode, it is still possible to define the mv-params block from the top level of the JSON file. For both single bench and multibench on the new schema, use blockbreaker w/ --config mv-params and --benchmark <benchmark name>. For single bench on the old schema, use --config mv-params and --index <index number>. This requires additional changes on the crucible code to fully support 'benchmarks' block from the json runfile, and then support it from the crucible cli.
rafaelfolco
force-pushed
the
all-in-one-multibench
branch
from
d058e8c
to
f7ed5f0
Compare
|
@k-rister pls review. I modified the schema by copying the mv-params block inside the benchmarks block. With this change, you can get a mv-params from the json with blockbreaker.py --json all-in-one.json --config mv-params --benchmark uperf. |
k-rister
approved these changes
Sep 19, 2023
atheurer
approved these changes
Sep 19, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmarks block to identify bench ids.
The blockbreaker utility extracts the benchmark
from the runfile and processes multibench config.
This requires additional changes on the crucible
code to fully support 'benchmarks' block from the
json runfile.