Fix redundant public accessibility analysis false-positive for proper…

…ty wrappers, closes #672

CHANGELOG.md

@@ -15,6 +15,7 @@
 - A newline is no longer printed before non-Xcode formatted results.
 - `--external-codable-protocols` now retains enums that conform to `CodingKey`.
 - Fix redundant public accessibility analysis false-positive for actors. 
+- Fix redundant public accessibility analysis false-positive for property wrappers.
 
 ## 2.17.1 (2023-12-04)
 

Sources/PeripheryKit/SourceGraph/Mutators/RedundantExplicitPublicAccessibilityMarker.swift

@@ -106,6 +106,8 @@ final class RedundantExplicitPublicAccessibilityMarker: SourceGraphMutator {
                         }
                     }
 
+                    return $0.parent
+                } else if decl.attributes.contains("propertyWrapper") {
                     return $0.parent
                 }
 

Tests/AccessibilityTests/AccessibilityProject/Sources/MainTarget/main.swift

@@ -64,3 +64,7 @@ let _ = PublicTypeUsedInPublicClosureRetainer().closure
 Task {
     await PublicActor().someFunc()
 }
+
+// Property wrappers
+
+_ = PublicWrappedProperty().wrappedProperty

Tests/AccessibilityTests/AccessibilityProject/Sources/TargetA/PublicWrappedProperty.swift

@@ -0,0 +1,17 @@
+import Foundation
+
+@propertyWrapper public struct PublicWrapper {
+  public var wrappedValue: String
+
+  public init(wrappedValue: String) {
+    self.wrappedValue = wrappedValue
+  }
+}
+
+public struct PublicWrappedProperty {
+  @PublicWrapper public var wrappedProperty: String
+
+  public init() {
+      wrappedProperty = ""
+  }
+}

Tests/AccessibilityTests/RedundantPublicAccessibilityTest.swift

@@ -259,4 +259,17 @@ class RedundantPublicAccessibilityTest: SourceGraphTestCase {
             self.assertNotRedundantPublicAccessibility(.functionMethodInstance("someFunc()"))
         }
     }
+
+    func testPublicWrappedProperty() {
+        Self.index()
+
+        assertNotRedundantPublicAccessibility(.struct("PublicWrapper")) {
+            self.assertNotRedundantPublicAccessibility(.varInstance("wrappedValue"))
+            self.assertNotRedundantPublicAccessibility(.functionConstructor("init(wrappedValue:)"))
+        }
+
+        assertNotRedundantPublicAccessibility(.struct("PublicWrappedProperty")) {
+            self.assertNotRedundantPublicAccessibility(.varInstance("wrappedProperty"))
+        }
+    }
 }