Test: unit tests for aggregate-report package #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armand1m
reviewed
Sep 28, 2018
armand1m
requested changes
Sep 28, 2018
armand1m
requested changes
Sep 28, 2018
| test('Testing aggregate report function', () => { | ||
| expect(aggregateReport(reportInfo)).toEqual(expectReport); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I think we should be strict into behavior-driven development here, you should be using it instead of test here, it would look a little bit like this:
describe('Aggregate Report', () => {
it('should return an object that matches the expected report', () => {
expect(aggregateReport(reportInfo)).toEqual(expectedReport);
});
});There was a problem hiding this comment.
I get the ideia, I'll fix today, thanks.
|
btw, related to #32 |
perry-js#32 Improvement in the description and variable name to be more like behavior driven development
armand1m
approved these changes
Sep 28, 2018
guilhermelimak
pushed a commit
to guilhermelimak/perry
that referenced
this pull request
Oct 21, 2018
Tests for aggregateReport module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial test to validate aggregate report, I'm not sure if this is a unit test, so I'd like more opinions about this.