Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PDF annotation #67

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

personalizedrefrigerator
Copy link
Owner

@personalizedrefrigerator personalizedrefrigerator commented Mar 28, 2024

Summary

Adds support for PDF annotation through a new @js-draw/pdf-support package. This package exposes an interface that must be implemented for whichever PDF backend is to be used.

To-do

  • Refactor MuPDF-related logic out of docs/examples/pdf-support and into a package that can be published to NPM.
    • Note: MuPDF is licensed under the GNU AGPLv3 — it will need to be made clear that this is the case in the package's README.
  • Better page memory management.
  • Support image annotations
  • Support highlight annotations
  • Support searching for PDF text
  • (Optional/follow-up PR) Support selecting PDF text
  • (Optional/follow-up PR) Support links
  • (Optional/follow-up PR) Support form conrols
  • (Optional) More memory-efficient saving of strokes.

Copy link

Visit the preview URL for this PR (updated for commit d42234c):

https://js-draw--pr67-work-pdf-support-r8ae15qu.web.app

(expires Thu, 04 Apr 2024 21:29:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e560ee6f7bb6b79cb55b42fb4c05e9fd1b5c506e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant