Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting checks disabled (possible erroneous?) #555

Open
aditya-vk opened this issue Oct 2, 2019 · 3 comments
Open

Formatting checks disabled (possible erroneous?) #555

aditya-vk opened this issue Oct 2, 2019 · 3 comments
Assignees

Comments

@aditya-vk
Copy link
Contributor

aditya-vk commented Oct 2, 2019

Two issues:

  1. Format checks are currently disabled. I think this was intentional during the shift to bionic and clang-format-6.0. We need to bring it back.

  2. I am not sure if the following issue is local to me (@madan96 can you please verify). a) Master still seems to need formatting corrections. And, b) On running the formatting command, Combine InteractiveMarkerViewer classes. #521 seems to still fail. For instance src/rviz/InteractiveMarkerViewer.cpp Line 206 is never corrected in its indentation. I have clang-format-6.0 on bionic.

@madan96
Copy link
Member

madan96 commented Oct 2, 2019

Yeah, I just checked and there seem to be some src files in rviz, perception and control subdirectories that still require formatting changes. Not sure how they got left out, there is no PR affecting these files, after #549 that was merged into master after this so I think that's where the problem is.

@madan96
Copy link
Member

madan96 commented Oct 2, 2019

@brianhou Should we run check-format for all builds or at least BIONIC_CATKIN_FULL_RELEASE?

@brianhou
Copy link
Contributor

brianhou commented Oct 3, 2019

We only need to check the formatting on one build.

@aditya-vk aditya-vk mentioned this issue Feb 26, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants