You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Format checks are currently disabled. I think this was intentional during the shift to bionic and clang-format-6.0. We need to bring it back.
I am not sure if the following issue is local to me (@madan96 can you please verify). a) Master still seems to need formatting corrections. And, b) On running the formatting command, Combine InteractiveMarkerViewer classes. #521 seems to still fail. For instance src/rviz/InteractiveMarkerViewer.cpp Line 206 is never corrected in its indentation. I have clang-format-6.0 on bionic.
The text was updated successfully, but these errors were encountered:
Yeah, I just checked and there seem to be some src files in rviz, perception and control subdirectories that still require formatting changes. Not sure how they got left out, there is no PR affecting these files, after #549 that was merged into master after this so I think that's where the problem is.
Two issues:
Format checks are currently disabled. I think this was intentional during the shift to bionic and clang-format-6.0. We need to bring it back.
I am not sure if the following issue is local to me (@madan96 can you please verify). a) Master still seems to need formatting corrections. And, b) On running the formatting command, Combine InteractiveMarkerViewer classes. #521 seems to still fail. For instance
src/rviz/InteractiveMarkerViewer.cpp
Line 206 is never corrected in its indentation. I have clang-format-6.0 on bionic.The text was updated successfully, but these errors were encountered: