Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added main script that allows for Calendar integration, and misc. changes #37

Merged
merged 5 commits into from
Jul 21, 2020

Conversation

LaRuim
Copy link

@LaRuim LaRuim commented Jul 19, 2020

#29
@souravtecken

This is a major commit, as a few changes overall were needed to facilitate the making of the main script.

  1. Created a main script called run.py. This fetches events from the Google Calendar, calls the appropriate scraper and does all the File I/O operations. It also has functions to update the database.

  2. Altered db_tools.py slightly to allow each function to be called from run.py

  3. Altered processor.py slightly to perform its task via the process method, to allow it to be called from run.py

  4. Removed unnecessary commented code and added explanatory comments over all files.

  5. Slightly altered the way logging is used over the entire project, standardizing it.

  6. Edited the README to reflect the changes in the way the project is structured.

  7. Edited requirements.txt to reflect dependencies better

To-do:

  1. Make HackerRank and Google scrapers compatible with the main script.
  2. Create a method to update README in the database folder after scraping.
  3. More error handling
  4. ?

Fixes #29

database/db_tools.py Outdated Show resolved Hide resolved
database/db_tools.py Outdated Show resolved Hide resolved
scrapers/README.md Show resolved Hide resolved
@LaRuim LaRuim requested a review from souravtecken July 20, 2020 16:07
@souravtecken souravtecken merged commit c09cd5e into pes-alcoding-club:dev Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants