chore: removes __destruct behaviour

pestphp · Nov 6, 2023 · e238c00 · e238c00
1 parent d129563
commit e238c00
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 34 deletions.
diff --git a/src/Factory.php b/src/Factory.php
@@ -4,9 +4,6 @@
 
 namespace Pest\Stressless;
 
-use Pest\TestSuite;
-use PHPUnit\Framework\TestCase;
-
 /**
  * @internal
  *
@@ -29,11 +26,6 @@ final class Factory
      */
     private int $duration = 5;
 
-    /**
-     * Weather or not the factory is running.
-     */
-    private bool $running = false;
-
     /**
      * The computed result, if any.
      */
@@ -102,16 +94,18 @@ public function for(int $duration): DurationOptions
      */
     public function run(): Result
     {
+        if ($this->result instanceof Result) {
+            return $this->result;
+        }
+
         $this->options['stages'] = [[
             'duration' => sprintf('%ds', $this->duration),
             'target' => $this->concurrency,
         ]];
 
         $this->options['throw'] = true;
 
-        $this->running = true;
-
-        return $this->result ??= ((new Run(
+        return $this->result = ((new Run(
             new Url($this->url),
             $this->options,
             $this->verbose,
@@ -171,24 +165,4 @@ public function __get(string $name): mixed
     {
         return $this->{$name}(); // @phpstan-ignore-line
     }
-
-    /**
-     * Destructs the run factory.
-     */
-    public function __destruct()
-    {
-        if ($this->result instanceof Result) {
-            return;
-        }
-
-        if (TestSuite::getInstance()->test instanceof TestCase) {
-            return;
-        }
-
-        if ($this->running) {
-            return;
-        }
-
-        $this->dd();
-    }
 }
diff --git a/src/Printers/Detail.php b/src/Printers/Detail.php
@@ -62,7 +62,7 @@ public function print(Result $result): void
 
         $color = $this->color($result->requests->upload->duration->avg, 50.0, 150.0, 250.0);
         $value = $result->requests->upload->duration->avg;
-        $percentage = $value * 100.0 / $total;
+        $percentage = $total === 0.0 ? 0.0 : ($value * 100.0 / $total);
         $percentage = sprintf('%4.1f', $percentage);
         $value = $this->ms($value);
 
@@ -83,7 +83,7 @@ public function print(Result $result): void
 
         $color = $this->color($result->requests->ttfb->duration->avg, 50.0, 150.0, 400.0);
         $value = $result->requests->ttfb->duration->avg;
-        $percentage = $value * 100.0 / $total;
+        $percentage = $total === 0.0 ? 0.0 : ($value * 100.0 / $total);
         $percentage = sprintf('%4.1f', $percentage);
         $value = $this->ms($value);
 
@@ -94,7 +94,7 @@ public function print(Result $result): void
 
         $color = $this->color($result->requests->download->duration->avg, 100.0, 300.0, 1000.0);
         $value = $result->requests->download->duration->avg;
-        $percentage = $value * 100.0 / $total;
+        $percentage = $total === 0.0 ? 0.0 : ($value * 100.0 / $total);
         $percentage = sprintf('%4.1f', $percentage);
         $value = $this->ms($value);