Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All http verbs #15

Merged
merged 8 commits into from
Dec 6, 2023
Merged

All http verbs #15

merged 8 commits into from
Dec 6, 2023

Conversation

nahime0
Copy link
Collaborator

@nahime0 nahime0 commented Dec 5, 2023

This PR introduces the remaining http verbs:

  • DELETE
  • HEAD
  • OPTIONS
  • PATCH
  • PUT

I've left the PR as a draft for now.

@nahime0 nahime0 marked this pull request as ready for review December 6, 2023 10:35
@nahime0 nahime0 requested a review from nunomaduro December 6, 2023 10:35
@nahime0
Copy link
Collaborator Author

nahime0 commented Dec 6, 2023

@nunomaduro a quick question: can I add the python "mock" server I use to test the requests in the repository?
In case, please suggest a folder where I can put the python file and the documentation on how to run it for local testing.

@nunomaduro
Copy link
Member

@nahime0 Yes you can. You decide where to put it. Thanks!

@nunomaduro nunomaduro marked this pull request as draft December 6, 2023 11:18
@nahime0
Copy link
Collaborator Author

nahime0 commented Dec 6, 2023

@nahime0 Yes you can. You decide where to put it. Thanks!

Thanks, I'll make a different PR for that

@nunomaduro nunomaduro marked this pull request as ready for review December 6, 2023 11:32
@nunomaduro nunomaduro merged commit 42934bc into 2.x Dec 6, 2023
36 checks passed
@nunomaduro nunomaduro deleted the all-http-verbs branch December 6, 2023 11:33
@nunomaduro
Copy link
Member

Can you PR docs for this PR?

@nahime0
Copy link
Collaborator Author

nahime0 commented Dec 6, 2023

Yes, working on it

@nahime0
Copy link
Collaborator Author

nahime0 commented Dec 6, 2023

PR ready: pestphp/docs#246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants